Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WebProfilerBundle] Update the logic that minimizes the toolbar#58380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.3fromjaviereguiluz:toolbar_minimize
Mar 29, 2025

Conversation

javiereguiluz
Copy link
Member

@javiereguiluzjaviereguiluz commentedSep 24, 2024
edited
Loading

QA
Branch?7.2
Bug fix?no
New feature?yes
Deprecations?no
Issues-
LicenseMIT

While working on fixing the accessibility issues of the toolbar (see#58366) I saw the following error reported:

Accesskey "D" is used more than once

This prevents the feature from working properly. So, in this PR I changed everything about how the toolbar is minimized:

  • Remove the "mini toolbar" (which is the button displayed when the toolbar is minimized)
  • Remove the.sf-toolbar-clearer element which is no longer needed
  • Transform the "hide" button into a "toggle" button to show/hide the toolbar
  • Update the show/hied logic to use CSS classes instead of juststyle: none/block

For end users nothing changes. It looks the same as before.

#SymfonyHackday

andreybolonin reacted with thumbs up emoji
@javiereguiluz
Copy link
MemberAuthor

@stof thanks a lot for the through review!

  • I fixed most of the issues that you pointed
  • About adding BC support for previous values, it's not worth it. The worst-case scenario is that someone had the toolbar closed an, after updating Symfony, the toolbar will be displayed. This is fine. Just click again on the close button.
  • Also, about close/open not being the same as show/hide ... it's true. But these changes don't modify the current behavior. The close/open buttons have been merged into a single toggle button which is always visible.

This is how it works on my local machine:

toolbar

@stof
Copy link
Member

@javiereguiluz it does change the existing behavior. In 7.1, we have 3 different state:

  • hidden toolbar, used while the Ajax request loading it is running
  • closed toolbar
  • opened toolbar

Your PR shows a closed toolbar during loading (and if loading fails, this will be quite confusing)

@javiereguiluz
Copy link
MemberAuthor

In my second commit I changed the default so the toolbar is visible by default. Would that be enough?

fabpot added a commit that referenced this pull requestSep 27, 2024
…panel (javiereguiluz)This PR was merged into the 7.2 branch.Discussion----------[WebProfilerBundle] Update the contents of the Config panel| Q             | A| ------------- | ---| Branch?       | 7.2| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Issues        | -lain below instead -->| License       | MITSimilar to#58366 and#58380, this fixes an accessibility issue of the Web Debug Toolbar:```The "title" attribute can't be used in non-interactive elements```It now looks like this:![image](https://github.com/user-attachments/assets/dff8d754-9661-40a7-81f9-5734f0ab36aa)Commits-------9f8d2f9 [WebProfilerBundle] Update the contents of the Config panel
@javiereguiluzjaviereguiluz added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelOct 3, 2024
@fabpotfabpot modified the milestones:7.2,7.3Nov 20, 2024
@javiereguiluzjaviereguiluz removed the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelDec 7, 2024
@javiereguiluz
Copy link
MemberAuthor

I've rebased this to Symfony 7.3 during the #SymfonyHackday of SymfonyCon 2024.

@OskarStarkOskarStark requested a review fromstofDecember 7, 2024 10:47
@fabpot
Copy link
Member

Thank you@javiereguiluz.

@fabpotfabpot merged commitcca60b4 intosymfony:7.3Mar 29, 2025
5 of 11 checks passed
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofAwaiting requested review from stof

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

4 participants
@javiereguiluz@stof@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp