Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[WebProfilerBundle] Update the logic that minimizes the toolbar#58380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.html.twigShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_js.html.twig OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_js.html.twigShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_js.html.twig OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_js.html.twigShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_js.html.twigShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_js.html.twig OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_js.html.twig OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
@stof thanks a lot for the through review!
This is how it works on my local machine: |
@javiereguiluz it does change the existing behavior. In 7.1, we have 3 different state:
Your PR shows a closed toolbar during loading (and if loading fails, this will be quite confusing) |
In my second commit I changed the default so the toolbar is visible by default. Would that be enough? |
…panel (javiereguiluz)This PR was merged into the 7.2 branch.Discussion----------[WebProfilerBundle] Update the contents of the Config panel| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | yes| Deprecations? | no| Issues | -lain below instead -->| License | MITSimilar to#58366 and#58380, this fixes an accessibility issue of the Web Debug Toolbar:```The "title" attribute can't be used in non-interactive elements```It now looks like this:Commits-------9f8d2f9 [WebProfilerBundle] Update the contents of the Config panel
afb9546
to14cb9d2
CompareI've rebased this to Symfony 7.3 during the #SymfonyHackday of SymfonyCon 2024. |
Thank you@javiereguiluz. |
cca60b4
intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
While working on fixing the accessibility issues of the toolbar (see#58366) I saw the following error reported:
This prevents the feature from working properly. So, in this PR I changed everything about how the toolbar is minimized:
.sf-toolbar-clearer
element which is no longer neededstyle: none/block
For end users nothing changes. It looks the same as before.
#SymfonyHackday