Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
run tests using PHPUnit 11.5#58370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:7.4
Are you sure you want to change the base?
Conversation
The PR cannot be merged at the moment as it is based on a bunch of other open pull requests that are paving the way to be able to actually run the tests with PHPUnit 11. |
7178ae5 to76245c5CompareThis is super nice news! Did you already take care of everything required to be "PHPUnit 11 compliant" in already opened PRs ? |
@alexandre-daubois The "ensure session storages are opened before destroying them" commit is the only one that is not already part of an open PR. I do not really understand yet why that change is necessary (the flow in |
76245c5 to24d86e8CompareThis PR was merged into the 5.4 branch.Discussion----------Tweak error/exception handler registration| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues |Fix#53812| License | MITThis should allow removing the custom bootstrap file from#58370 /cc `@xabbuh`The change on FrameworkBundle leads to a tweaked behavior: we don't override the previous error handler in case it's not the Symfony one. This shouldn't change anything in practice since the error handler is already registered by the runtime component.The rest is closer to bug fixes.Commits-------af9c035 Tweak error/exception handler registration
We need a way to register DebugClassLoader, and maybe a few other things. Basically what we do in SymfonyTestsListenerTrait. |
ab2f604 toe56f932Comparee56f932 tobddc3f5Compared72eadc toc89477aCompare70f5b92 to3e19ea6Compare
Isn't that related to how our CI is configured? I mean the previous commit that is checked out does not have the changes needed in |
39cc605 toca642e4Compare| @@ -30,7 +30,7 @@ | |||
| "symfony/dependency-injection": "^6.4|^7.0", | |||
| "symfony/doctrine-messenger": "^6.4|^7.0", | |||
| "symfony/expression-language": "^6.4|^7.0", | |||
| "symfony/form": "^6.4.6|^7.0.6", | |||
| "symfony/form": "^7.2", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
because we need#58357
This PR was merged into the 7.3 branch.Discussion----------[Translation] drop support for nikic/php-parser 4| Q | A| ------------- | ---| Branch? | 7.3| Bug fix? | no| New feature? | no| Deprecations? | no| Issues || License | MITExtracted from#58370, background: PHPUnit 11 is no longer compatible with `nikic/php-parser` 4 (see#58370 (comment)).Commits-------2676ce9 drop support for nikic/php-parser 4
890b854 to8f0b304Comparecb7741d to84443c0CompareThis PR was merged into the 6.4 branch.Discussion----------[FrameworkBundle] make data provider static| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | no| New feature? | no| Deprecations? | no| Issues || License | MITspotted in#58370 (I missed this in#60365)Commits-------04a46d3 make data provider static
cfa0923 to8a20f9fCompare8a20f9f to7296609Comparea440ba5 to1063ab5Compare1063ab5 to5e4fdbaCompare5e4fdba toae5c4c9Compare
Uh oh!
There was an error while loading.Please reload this page.