Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Serializer] Readd AdvancedNameConverterInterface to MetadataAwareNameConverter#58368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:7.1fromaurimasrim:fix_58294
Sep 24, 2024

Conversation

@aurimasrim
Copy link
Contributor

[Serializer] Readd AdvancedNameConverterInterface to MetadataAwareNameConverter

QA
Branch?7.1
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#58294
LicenseMIT

Fixes BC break introduced in a minor version 7.1

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@xabbuh
Copy link
Member

The change looks good to me. I shouldn't have changed that in#54531.

@nicolas-grekas
Copy link
Member

Thank you@aurimasrim.

aurimasrim reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commit3c7124e intosymfony:7.1Sep 24, 2024
9 of 10 checks passed
@aurimasrimaurimasrim deleted the fix_58294 branchSeptember 24, 2024 11:07
@fabpotfabpot mentioned this pull requestOct 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh approved these changes

@alexandre-dauboisalexandre-dauboisalexandre-daubois approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

5 participants

@aurimasrim@carsonbot@xabbuh@nicolas-grekas@alexandre-daubois

[8]ページ先頭

©2009-2025 Movatter.jp