NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[Console] Suppress`proc_open` errors within`Terminal::readFromProcess`#58332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromfritzmg:suppress-read-from-process-errors

Sep 28, 2024

Merged

[Console] Suppress`proc_open` errors within`Terminal::readFromProcess`#58332

nicolas-grekas merged 1 commit intosymfony:5.4fromfritzmg:suppress-read-from-process-errors

Sep 28, 2024

Conversation

Copy link

Contributor

fritzmg commentedSep 20, 2024•
edited
Loading

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues
License	MIT

When instantiatingSymfonyStyle in a command it will try to determine the maximum width of the current console interface.

symfony/src/Symfony/Component/Console/Style/SymfonyStyle.php

Line 53 in6687e4e

$width = (newTerminal())->getWidth() ?:self::MAX_LINE_LENGTH;

This will executestty -a | grep columns down the line. Access tostty might be disallowed however, resulting in the following error:

ErrorException: Warning: proc_open(): Exec failed: Permission denied#16 /vendor/symfony/console/Terminal.php(220): Symfony\Component\Console\Terminal::readFromProcess#15 /vendor/symfony/console/Terminal.php(204): Symfony\Component\Console\Terminal::getSttyColumns#14 /vendor/symfony/console/Terminal.php(170): Symfony\Component\Console\Terminal::initDimensionsUsingStty#13 /vendor/symfony/console/Terminal.php(153): Symfony\Component\Console\Terminal::initDimensions#12 /vendor/symfony/console/Terminal.php(94): Symfony\Component\Console\Terminal::getWidth#11 /vendor/symfony/console/Style/SymfonyStyle.php(55): Symfony\Component\Console\Style\SymfonyStyle::__construct#10 /vendor/symfony/messenger/Command/ConsumeMessagesCommand.php(136): Symfony\Component\Messenger\Command\ConsumeMessagesCommand::interact#9 /vendor/symfony/console/Command/Command.php(311): Symfony\Component\Console\Command\Command::run

(Stack Trace actually from Symfony 6)

The phpDoc ofTerminal::getSttyColumns states

Runs and parses stty -a if it's available,suppressing any error output.

The latter might refer to['suppress_errors' => true] (though I am not sure) - which is a Windows only functionality. In any case, sinceTerminal::readFromProcess already checks for

if (!$process =proc_open(…)) {returnnull;}

and

if (!\is_resource($process)) {returnnull;}

upstream in Symfony 6/7, indicating thatproc_open might fail - this error can additionally be suppressed using@. Besides,Process::start also uses@proc_open (added in099481f "Prevent warning in proc_open()").

suppress proc_open errors

575249a

fritzmg requested a review fromchalasr as acode owner

September 20, 2024 10:49

carsonbot added Status: Needs Review Bug Console labels

Sep 20, 2024

carsonbot added this to the7.2 milestone

Sep 20, 2024

Copy link

carsonbot commentedSep 20, 2024

Hey!

Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch "5.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot