Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] DeprecateAdvancedNameConverterInterface#58308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Serializer] DeprecateAdvancedNameConverterInterface#58308
Uh oh!
There was an error while loading.Please reload this page.
Conversation
chalasr commentedSep 21, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
That interface looks indeed useless since 7.1.@xabbuh can you have a look as you were the one making NameConverterInterface methods' signatures the same as the |
xabbuh commentedSep 24, 2024
👍 looks good to me |
e5ec432 toac0f41fComparemtarld commentedSep 24, 2024
@chalasr, the |
chalasr commentedSep 24, 2024
Can you please rebase now that#58368 is merged to ensure tests keep passing despite an implementation exists in core? |
ac0f41f to0a263d0Comparefabpot commentedSep 27, 2024
Thank you@mtarld. |
9bc8007 intosymfony:7.2Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Deprecate the
AdvancedNameConverterInterfacein favor ofNameConverterInterfaceas they'll have the same signature in 8.0