Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Serializer] DeprecateAdvancedNameConverterInterface#58308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@mtarld
Copy link
Contributor

@mtarldmtarld commentedSep 18, 2024
edited
Loading

QA
Branch?7.2
Bug fix?no
New feature?no
Deprecations?yes
Issues
LicenseMIT

Deprecate theAdvancedNameConverterInterface in favor ofNameConverterInterface as they'll have the same signature in 8.0

@chalasr
Copy link
Member

chalasr commentedSep 21, 2024
edited
Loading

That interface looks indeed useless since 7.1.@xabbuh can you have a look as you were the one making NameConverterInterface methods' signatures the same as theAdvancedNameConverterInterface in 7.1?
If this is what we want, we probably need to add@param phpdoc annotations to each method ofNameConverterInterface for the new params, to leverageDebugClassLoader's deprecation system.

@xabbuh
Copy link
Member

👍 looks good to me

@mtarldmtarldforce-pushed thefeat/deprecate-advanced-name-converter-interface branch frome5ec432 toac0f41fCompareSeptember 24, 2024 08:21
@mtarld
Copy link
ContributorAuthor

@chalasr, the@param annotations are already on top ofNameConverterInterface related methods.

chalasr reacted with thumbs up emoji

@chalasr
Copy link
Member

Can you please rebase now that#58368 is merged to ensure tests keep passing despite an implementation exists in core?

@mtarldmtarldforce-pushed thefeat/deprecate-advanced-name-converter-interface branch fromac0f41f to0a263d0CompareSeptember 25, 2024 07:20
@fabpot
Copy link
Member

Thank you@mtarld.

@fabpotfabpot merged commit9bc8007 intosymfony:7.2Sep 27, 2024
8 checks passed
@mtarldmtarld deleted the feat/deprecate-advanced-name-converter-interface branchSeptember 27, 2024 08:42
@fabpotfabpot mentioned this pull requestOct 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

@chalasrchalasrchalasr approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

7.2

Development

Successfully merging this pull request may close these issues.

5 participants

@mtarld@chalasr@xabbuh@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp