Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Re-addAdvancedNameConverterInterface#58307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@mtarld
Copy link
Contributor

@mtarldmtarld commentedSep 18, 2024•
edited
Loading

QA
Branch?7.1
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#58294
LicenseMIT

Re-addAdvancedNameConverterInterface on top ofCamelCaseToSnakeCaseNameConverter andMetadataAwareNameConverter.

@mtarldmtarldforce-pushed thefix/advanced-name-converter-interface-removal branch from7d989bc to222fb4cCompareSeptember 18, 2024 17:26
@mtarldmtarld changed the title[Serializer] Re-addAdvancedNameConverterInterface as deprecated[Serializer] Re-addAdvancedNameConverterInterfaceSep 18, 2024
* @author Aurélien Pillevesse <aurelienpillevesse@hotmail.fr>
*/
class CamelCaseToSnakeCaseNameConverterimplements NameConverterInterface
class CamelCaseToSnakeCaseNameConverterimplements NameConverterInterface, AdvancedNameConverterInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

CamelCaseToSnakeCaseNameConverter wasnot an advanced converter in 7.0 so there is nothing to re-add there, and adding the arguments in the signature natively is a BC break for child classes.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Indeed, you're right, plus I didn't get all the history of that PR (#53898 (comment)).

I'm going to close that PR, thanks!

@mtarldmtarld closed thisSep 18, 2024
@mtarldmtarld deleted the fix/advanced-name-converter-interface-removal branchNovember 15, 2024 10:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@mtarld@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp