Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Process] Fix finding executables independently of open_basedir#58291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Issues-
LicenseMIT

This backports#47422 to 5.4, which is a bugfix really.

Instead of#58008 and#57954 /cc@xabbuh@fritzmg

@nicolas-grekas
Copy link
MemberAuthor

Thank you@BlackbitDevs.

@nicolas-grekasnicolas-grekas merged commit796fff2 intosymfony:5.4Sep 17, 2024
Copy link
Contributor

@fritzmgfritzmg left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

But shouldn't theopen_basedir paths be checkedadditionally? After all,open_basedir could contain other paths with available executables thanPATH. This is why I did not consider just backporting the state of Symony 6+ to 5.4.

@nicolas-grekasnicolas-grekas deleted the proc-openbasedir branchSeptember 17, 2024 12:53
@nicolas-grekas
Copy link
MemberAuthor

That'd be incorrect, open_basedir is not meant to replace PATH

@fritzmg
Copy link
Contributor

That'd be incorrect, open_basedir is not meant to replace PATH

That was not my point.open_basedir andPATH are two completely different things. My point is that an executable that is available in the system does not necessarily have to be defined inPATH - but its location might be still hinted via theopen_basedir setting in some environments.

However, since the usage ofopen_basedir is discouraged anyway, this likely will not matter that much in the end.

@stof
Copy link
Member

@fritzmg open_basedir is not about hinting about the location of executables at all.

@fritzmg
Copy link
Contributor

fritzmg commentedSep 17, 2024
edited
Loading

@fritzmg open_basedir is not about hinting about the location of executables at all.

Not directly, no. But if a hosting environment employsopen_basedir, it needs to add all paths to exectuables that the PHP environment should have access to to theopen_basedir paths. Hence whyopen_basedir can be used as an additional source to finding executables via theExecutableFinder.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

+1 more reviewer

@fritzmgfritzmgfritzmg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas@fritzmg@stof@carsonbot@BlackbitDevs

[8]ページ先頭

©2009-2025 Movatter.jp