NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[ExpressionLanguage] Fix matches to handle booleans being used as regexp#58261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:7.2fromivantsepp:expression-language-matches-compile-on-binary-node

Oct 6, 2024

Merged

[ExpressionLanguage] Fix matches to handle booleans being used as regexp#58261

fabpot merged 1 commit intosymfony:7.2fromivantsepp:expression-language-matches-compile-on-binary-node

Oct 6, 2024

Conversation

Copy link

Contributor

ivantsepp commentedSep 13, 2024•
edited
Loading

Q	A
Branch?	7.2
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	n/a
License	MIT

I'm marking this as a bug fix but this could be seen as a "new feature" as existingmatches syntax functionality works just fine.

I wanted to build on top of the work done at#45875. This handles invalid regular expressions and also does an extra check inside thecompile method. It checks the right hand side for aConstantNode and validates that it's a valid regexp. The idea is that we can goeven further and check forBinaryNode because in most cases, this is an invalid regexp since a boolean usually returned. The exception is~ which is for string concatenation since that could result in a valid regexp.

This extra check could help prevent invalid expressions like"a" matches ("/a/" || "/b/") where one could mistake"/a/" || "/b/" as being a valid regexp (when the correct approach would've been"a" matches "/a|b/")

carsonbot added Status: Needs Review Bug ExpressionLanguage labels

Sep 13, 2024

carsonbot added this to the7.2 milestone

Sep 13, 2024

Copy link

carsonbot commentedSep 13, 2024

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link

carsonbot commentedSep 13, 2024

Hey!

Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch "7.2 for features / 5.4, 6.4, and 7.1 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot