NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Cache] Fix RedisSentinel param types#58260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromstasicki:redis_sentinel_constructor_params_fix

Sep 16, 2024

Merged

[Cache] Fix RedisSentinel param types#58260

nicolas-grekas merged 1 commit intosymfony:5.4fromstasicki:redis_sentinel_constructor_params_fix

Sep 16, 2024

Conversation

Copy link

stasicki commentedSep 13, 2024

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues
License	MIT

Parameters passed as strings from parse_url to \RedisSentinel constructor cause an exception.

RedisException : Invalid retry interval in /app/symfony/src/Symfony/Component/Cache/Traits/RedisTrait.php:236

Applies to redis-ext above 6.0.0

[Cache] Fix RedisSentinel params types

cf73c7e

carsonbot added Status: Needs Review Bug Cache labels

Sep 13, 2024

carsonbot added this to the5.4 milestone

Sep 13, 2024

Copy link

carsonbot commentedSep 13, 2024

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot