$container->reset() must still be called, to reset the instances hold by the container itself (see the code of line 302).

Btw, if you ensure that theservices_resetter service is instantiated, the container reset call will then call it (as ServiceResetter implements the ResetInterface).

The reason it was not called is becauseContainer::reset only resetsinstantiated resettable services

@stof Fixed, seehttps://github.com/symfony/symfony/compare/549ada5257c771da92d51aff76e224e1ac5d31f4..5491aa54a3205acfaf5ba62c134bddc26d794a36

Initially, I wanted to just instantiate theservices_resetter and letContainer::reset() call reset on it, but that didn’t work because theservices_resetter only resets instantiated services. Because of line 302, by the time it’s called, there aren’t any instantiated services left.

The downside of the current approach is that some services will get reset twice, but I don’t see a better solution at the moment.

ah indeed. The container resets itself before resetting the services.

I think this might actually be an issue if thereset method of a service triggers the instantiation of some other service. I think the resetting of the container state should probably be moved after the loop.

@stof Donehttps://github.com/symfony/symfony/compare/5491aa54a3205acfaf5ba62c134bddc26d794a36..53d0f56be6a315055cb3ceef09a7f6bcb233a120