Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer][Uid][Validator] Mention RFC 9562#58238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| publicconstNORMALIZATION_FORMAT_BASE58 ='base58'; | ||
| publicconstNORMALIZATION_FORMAT_BASE32 ='base32'; | ||
| publicconstNORMALIZATION_FORMAT_RFC4122 ='rfc4122'; | ||
| publicconstNORMALIZATION_FORMAT_RFC4122 ='rfc4122';// RFC 9562 obsoleted RFC 4122 but the format is the same |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We might addpublic const NORMALIZATION_FORMAT_RFC9562 = self::NORMALIZATION_FORMAT_RFC4122; in Symfony 7.2 in case some people look for the format for RFC 9562.
stof approved these changesSep 11, 2024
dunglas approved these changesSep 12, 2024
derrabus approved these changesSep 14, 2024
xabbuh approved these changesSep 15, 2024
nicolas-grekas added a commit that referenced this pull requestSep 16, 2024
…`UidNormalizer::NORMALIZATION_FORMAT_RFC9562` constants (alexandre-daubois)This PR was merged into the 7.2 branch.Discussion----------[Serializer][Uid] Add the `Uuid::FORMAT_RFC_9562` and `UidNormalizer::NORMALIZATION_FORMAT_RFC9562` constants| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | yes| Deprecations? | no| Issues | -| License | MITFollowing#58238 (cc `@fancyweb`), for completeness of this 7.2 feature.Commits-------f84170a [Serializer][Uid] Add the `Uuid::FORMAT_RFC_9562` and `UidNormalizer::NORMALIZATION_FORMAT_RFC9562` constants
Member
nicolas-grekas commentedSep 16, 2024
Thank you@fancyweb. |
fabpot added a commit that referenced this pull requestSep 21, 2024
This PR was merged into the 6.4 branch.Discussion----------[Routing][Uid] [6.4] Mention RFC 9562| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | no| New feature? | no| Deprecations? | no| Issues | -| License | MITFollow-up to#58238 on 6.4Commits-------edf9916 [6.4][Routing][Uid] Mention RFC 9562
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 4122 has been obsoleted by RFC 9562 since May 2024.
The format remains the same so we don't need to do anything. Renaming everything with BC would certainly be a waste of time. However, we can add some comments and update the links to be up-to-date.