Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Deprecate sms77 Notifier bridge#58200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.3fromMrYamous:notifier/deprecate-sms77
Mar 29, 2025

Conversation

MrYamous
Copy link
Contributor

@MrYamousMrYamous commentedSep 8, 2024•
edited by OskarStark
Loading

QA
Branch?7.3
Bug fix?no
New feature?no
Deprecations?yes
IssuesFollowing#52936
LicenseMIT

#52936 introduced a new Seven.io bridge for Notifier component to replace sms77 but this one has not been deprecated

@OskarStark
Copy link
Contributor

As far as I remember, we decided not to deprecate it, just mention the new bridge and exclude it from new releases.

Is that true@fabpot ?

@nicolas-grekas
Copy link
Member

we decided not to deprecate it

reading#52936, it looks like we decided to postpone the deprecation to another PR, so here we are, this PR looks legit to me

@MrYamous
Copy link
ContributorAuthor

Thanks for reviews ! I've applied suggested changes, and fix CS according to fabbot

@MrYamousMrYamousforce-pushed thenotifier/deprecate-sms77 branch fromb78d314 to9b95102CompareOctober 6, 2024 04:43
@MrYamous
Copy link
ContributorAuthor

MrYamous commentedOct 6, 2024•
edited
Loading

I think i'm up to date with requested changes, and rebased for pending conflicts

@fabpotfabpot modified the milestones:7.2,7.3Nov 20, 2024
Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Tests are failing as we're still using some deprecated code somewhere without proper annotations. Can you have a look? Thank you.

@MrYamous
Copy link
ContributorAuthor

Tests are failing as we're still using some deprecated code somewhere without proper annotations. Can you have a look? Thank you.

Thanks for reminding me this, I think it's better now :)

@fabpot
Copy link
Member

It looks like tests are still failing.

@OskarStark
Copy link
Contributor

@MrYamous up to finish this PR?

@MrYamous
Copy link
ContributorAuthor

@MrYamous up to finish this PR?

@OskarStark Yes i'm going to finish this PR

@MrYamousMrYamousforce-pushed thenotifier/deprecate-sms77 branch from9bdd6ca to7ea4279CompareFebruary 28, 2025 15:07
@MrYamous
Copy link
ContributorAuthor

I've made some changes and rebased, I'm not sure but fails seems unrelated

@fabpotfabpotforce-pushed thenotifier/deprecate-sms77 branch from7ea4279 to006ea39CompareMarch 29, 2025 11:39
@fabpot
Copy link
Member

Thank you@MrYamous.

@fabpotfabpot merged commit764fe52 intosymfony:7.3Mar 29, 2025
5 of 11 checks passed
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof left review comments

@xabbuhxabbuhxabbuh left review comments

@chalasrchalasrchalasr left review comments

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

8 participants
@MrYamous@OskarStark@nicolas-grekas@fabpot@stof@xabbuh@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp