Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Filesystem] make sure temp files can be cleaned up on Windows#58185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
xabbuh commentedSep 5, 2024
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
d7e4e79 toa832b67Comparenicolas-grekas approved these changesSep 11, 2024
Good catch, thanks@xabbuh. |
nicolas-grekas added a commit that referenced this pull requestSep 18, 2024
This PR was merged into the 7.2 branch.Discussion----------[Filesystem] revert test changes| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | no| Deprecations? | no| Issues || License | MITwe can revert#58152 now that the underlying bug was fixed with#58185Commits-------5ea44be revert test changes
This was referencedSep 21, 2024
Merged
Merged
Merged
github-merge-queuebot pushed a commit to Lendable/composer-license-checker that referenced this pull requestSep 23, 2024
This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---||[phpstan/phpstan-strict-rules](https://redirect.github.com/phpstan/phpstan-strict-rules)| `1.6.0` -> `1.6.1` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [symfony/filesystem](https://symfony.com)([source](https://redirect.github.com/symfony/filesystem)) | `6.4.9` ->`6.4.12` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>phpstan/phpstan-strict-rules(phpstan/phpstan-strict-rules)</summary>###[`v1.6.1`](https://redirect.github.com/phpstan/phpstan-strict-rules/releases/tag/1.6.1)[CompareSource](https://redirect.github.com/phpstan/phpstan-strict-rules/compare/1.6.0...1.6.1)-[daeec74](http://github.com/phpstan/phpstan-strict-rules/commit/daeec748b53de80a97498462513066834ec28f8b)- Check if treatPhpDocTypesAsCertain tip is enabled-[876574c](http://github.com/phpstan/phpstan-strict-rules/commit/876574c426cfc6531ef26c799d20f0cb97d82f48)- Fix build-[a567f7b](http://github.com/phpstan/phpstan-strict-rules/commit/a567f7b0e5dfe524cc84f177fe5ca2b81f49b92a)- Pin build-cs-[2462e57](http://github.com/phpstan/phpstan-strict-rules/commit/2462e578b2f9b89d0774d284d139d2cd702729bb)- Test newer PHP versions</details><details><summary>symfony/filesystem (symfony/filesystem)</summary>###[`v6.4.12`](https://redirect.github.com/symfony/filesystem/releases/tag/v6.4.12)[CompareSource](https://redirect.github.com/symfony/filesystem/compare/v6.4.9...v6.4.12)**Changelog**(symfony/filesystem@v6.4.11...v6.4.12)- bug[symfony/symfony#58185](https://redirect.github.com/symfony/symfony/issues/58185)\[Filesystem] make sure temp files can be cleaned up on Windows([@​xabbuh](https://redirect.github.com/xabbuh))</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.👻 **Immortal**: This PR will be recreated if closed unmerged. Get[confighelp](https://redirect.github.com/renovatebot/renovate/discussions) ifthat's undesired.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR was generated by [Mend Renovate](https://mend.io/renovate/).View the [repository joblog](https://developer.mend.io/github/Lendable/composer-license-checker).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
based on the findings while debugging the AppVeyor failures that we worked around in#58152