Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpFoundation][FrameworkBundle] AddBinaryFileResponse::setXSendfileHeader() and corresponding config option to help configure upload acceleration#58162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?7.2
Bug fix?no
New feature?yes
Deprecations?no
Issues-
LicenseMIT

Follows#58161 (comment) (and embeds the corresponding commit for now)

@carsonbotcarsonbot added this to the7.2 milestoneSep 3, 2024
@nicolas-grekasnicolas-grekas changed the titleFwb x sendfile header[HttpFoundation][FrameworkBundle] Add BinaryFileResponse::setXSendfileHeader() and corresponding config option to help configure upload accelerationSep 3, 2024
…S`, `SYMFONY_TRUSTED_HEADERS`, `SYMFONY_TRUST_X_SENDFILE_TYPE_HEADER` and `SYMFONY_TRUSTED_HOSTS` env vars
…eHeader() and corresponding config option to help configure upload acceleration
@OskarStarkOskarStark changed the title[HttpFoundation][FrameworkBundle] Add BinaryFileResponse::setXSendfileHeader() and corresponding config option to help configure upload acceleration[HttpFoundation][FrameworkBundle] AddBinaryFileResponse::setXSendfileHeader() and corresponding config option to help configure upload accelerationSep 5, 2024
@nicolas-grekas
Copy link
MemberAuthor

Let me withdraw this PR: X-Senfile-Type is coming from the RoR world, and requires the server to send an X-Accel-Mapping header anyway so there is always something to configure on the server-side (at least for nginx)

Seehttps://github.com/rack/rack/blob/main/lib/rack/sendfile.rb andhttps://mattbrictson.com/blog/accelerated-rails-downloads for more on the topic.

@nicolas-grekas
Copy link
MemberAuthor

See also#58181

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

Assignees

No one assigned

Projects

None yet

Milestone

7.2

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolas-grekas@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp