Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[DependencyInjection] Add support forkey-type
inXmlFileLoader
#58035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
d3f0395
tofe4500c
Comparesrc/Symfony/Component/DependencyInjection/Loader/schema/dic/services/services-1.0.xsd OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/DependencyInjection/Loader/schema/dic/services/services-1.0.xsd OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
fe4500c
tobf2b02e
Comparenicolas-grekas approved these changesAug 20, 2024
fabpot approved these changesAug 27, 2024
Thank you@alexandre-daubois. |
20bda2b
intosymfony:7.2 8 of 10 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Merged
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestNov 27, 2024
This PR was merged into the 6.4 branch.Discussion----------[Routing] Add example of Requirement enum[Requirement Enum](https://github.com/symfony/symfony/blob/6.4/src/Symfony/Component/Routing/Requirement/Requirement.php) values are not cases but constants.So in YAML routing format we must use `!php/const` instead of `!php/enum`.This PR add examples to how to use the "Requirement enum"Can you confirm constants are not supported in XML format for routing ? (if not, maybe we can make PR likesymfony/symfony#58035 cc `@alexandre`-daubois)Commits-------ebfa5e2 [Routing] Add example of Requirement enum
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestJan 13, 2025
…e (phansys)This PR was merged into the 7.2 branch.Discussion----------[Doctrine] Use PDO constants in XML configuration exampleFollows#20557, in this case for XML.Seesymfony/symfony#58035.I guess this PR should be merged after merging the 7.1 branch.Commits-------c880a88 [Doctrine] Use PDO constants in XML configuration example
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Quoting the tests to show how this works:
Makes the following pass: