Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] remove custom CSV escape character from tests#58021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedAug 16, 2024
Do we keep one as |
xabbuh commentedAug 16, 2024
none of the tests actually depends on the value of the escape character, not sure if we want to add a new test covering it explicitly |
chalasr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we deprecate theCsvEncoder::ESCAPE_CHAR_KEYcontext key on 7.2?
nicolas-grekas commentedAug 16, 2024
xabbuh commentedAug 16, 2024
@chalasr I think@alexandre-daubois should have that covered in#57827 |
alexandre-daubois commentedAug 16, 2024
Indeed, I'll address the remaining comment in a couple of days. Thanks for this complementary PR! |
nicolas-grekas commentedAug 16, 2024
Isn't the failing test related? |
xabbuh commentedAug 16, 2024
indeed, fixed |
nicolas-grekas commentedAug 16, 2024
Thank you@xabbuh. |
This PR was merged into the 6.4 branch.Discussion----------[Serializer] clean up PHP version checks| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | no| New feature? | no| Deprecations? | no| Issues || License | MITthese checks are not needed after merging#58021 up into the `6.4` branchCommits-------6e19c0f clean up PHP version checks
Uh oh!
There was an error while loading.Please reload this page.
using custom escape character will be deprecated from PHP 8.4