Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Messenger] Allow setting retry delay byRecoverableExceptionInterface#57915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

valtzu
Copy link
Contributor

@valtzuvaltzu commentedAug 3, 2024
edited
Loading

QA
Branch?7.2
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#57756
LicenseMIT

Allow overriding retry delay from the retry strategy by providing it in the exception. Example use case is retrying http request based onRetry-After header.

jannes-io reacted with heart emoji
@valtzuvaltzuforce-pushed theuse-retry-delay-from-throwable branch from77c2847 to7d7f161CompareAugust 4, 2024 15:00
@nicolas-grekasnicolas-grekasforce-pushed theuse-retry-delay-from-throwable branch from183a23c to68a096cCompareAugust 13, 2024 10:21
@nicolas-grekas
Copy link
Member

Thank you@valtzu.

@nicolas-grekasnicolas-grekas merged commit00c81a7 intosymfony:7.2Aug 13, 2024
5 of 10 checks passed
@OskarStarkOskarStark changed the title[Messenger] Allow setting retry delay by RecoverableExceptionInterface[Messenger] Allow setting retry delay byRecoverableExceptionInterfaceAug 15, 2024
@fabpotfabpot mentioned this pull requestOct 27, 2024
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestDec 2, 2024
This PR was squashed before being merged into the 7.2 branch.Discussion----------[Messenger] Document `getRetryDelay()`Documentation for code [57915](symfony/symfony#57915)Commits-------646e199 [Messenger] Document `getRetryDelay()`
fabpot added a commit that referenced this pull requestJan 25, 2025
…xceptionInterface` (AydinHassan)This PR was merged into the 7.2 branch.Discussion----------[Messenger ] Extract retry delay from nested `RecoverableExceptionInterface`| Q             | A| ------------- | ---| Branch?       | 7.2| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        | n/a| License       | MITHey,In#57915 the ability to add a retry delay to `RecoverableExceptionInterface` was implemented. However, I noticed while debugging that it in my case the custom delay was not being applied because `RecoverableExceptionInterface` is wrapped in a `HandlerFailedException` in:https://github.com/symfony/symfony/blob/7a16efefdee2d282cd6ccfd6ecb0b82ff5a06936/src/Symfony/Component/Messenger/Middleware/HandleMessageMiddleware.php#L124For detecting whether we should retry we already unwrap `HandlerFailedException` so I implemented a similar method to fetch the delay, simply getting it from the first `RecoverableExceptionInterface`.Maybe we need something more advanced, so your feedback there would be appreciated!Commits-------4a02222 [Messenger ] Extract retry delay from nested `RecoverableExceptionInterface`
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@94noni94noni94noni left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.

[Messenger] Add option to set custom delay on RecoverableMessageHandlingException
4 participants
@valtzu@nicolas-grekas@94noni@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp