Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer] Implement Postal mailer#57903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.2fromjonasclaes:7.2
Aug 11, 2024
Merged

[Mailer] Implement Postal mailer#57903

fabpot merged 1 commit intosymfony:7.2fromjonasclaes:7.2
Aug 11, 2024

Conversation

@jonasclaes
Copy link
Contributor

@jonasclaesjonasclaes commentedAug 1, 2024•
edited
Loading

QA
Branch?7.2
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT

This will implement the Postal mailer.

API docs:https://apiv1.postalserver.io/controllers/send/message.html

Docs:symfony/symfony-docs#20088

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've suggested a small CS fix.

Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

some small CS changes, the code itself looks good to me besides that

@fabpot
Copy link
Member

Thank you@jonasclaes.

@fabpotfabpot merged commitcf3dfb6 intosymfony:7.2Aug 11, 2024
@fabpot
Copy link
Member

@jonasclaes Can you create a recipe onhttps://github.com/symfony/recipes?

@jonasclaes
Copy link
ContributorAuthor

@jonasclaes Can you create a recipe onhttps://github.com/symfony/recipes?

symfony/recipes#1332

All done! Let me know if I missed something. First time!

@fabpotfabpot mentioned this pull requestOct 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

7.2

Development

Successfully merging this pull request may close these issues.

5 participants

@jonasclaes@carsonbot@fabpot@OskarStark@xabbuh
[8]ページ先頭
©2009-2025 Movatter.jp