@mtarld@chalasr I could need your help here as I am not sure that this is really the best way to fix the test failures. Basically, this PR reverts#57825. On the7.1 branch this change was necessary as theReflectionExtractor does not pass any resolvers toTypeResolver::create() which in turn means that the newPhpDocAwareReflectionTypeResolver will be used. On the7.2 branch we are explicit and this means that the newPhpDocAwareReflectionTypeResolver is not used (is that intended)?

@xabbuh The reasoning behind not wiring thePhpDocAwareReflectionTypeResolver in PropertyInfo is that PropertyInfo has its own implementation for extracting types from phpdoc (PhpStanTypeHelper). I'm not entirely sure but as far as I understand that helper is only used by the to-be-deprecatedPropertyTypeExtractorInterface::getTypes(), not the new type-info basedgetType(). If I'm right, then we should probably just always wirePhpDocAwareReflectionTypeResolver and keep relying onTypeResolver::create() on 7.2.

Mathias is on vacation for 2 weeks so I suggest merging this PR, he will revisit the topic once it gets back.
Thanks for the PRs

Hey@xabbuh,
TheReflectionExtractor ofPropertyInfo is by definition not aware of phpdoc.
This is the wiring (ie: the service definition) that enable that feature using decoration.

Therefore, we cannot give thePhpDocAwareTypeResolver to theReflectionExtractor, because if so, it won't behave at it used to be.

This is strange that tests are failing in 7.1 though. This might be because of cross-component weird dependencies (ie: property-info in "raw 7.1" and type-info in 7.1 with thePhpDocAwareTypeResolver)