Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Translation] Fix CSV escape char inCsvFileLoader on PHP >= 7.4#57828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromalexandre-daubois:csv-escape
Jul 26, 2024

Conversation

@alexandre-daubois
Copy link
Member

QA
Branch?5.4
Bug fix?no
New feature?no
Deprecations?no
Issues-
LicenseMIT

Related to#57827. This check has already been done in other places like:

returnstr_getcsv($env,',','"', \PHP_VERSION_ID >=70400 ?'' :'\\');

@carsonbot

This comment has been minimized.

@carsonbotcarsonbot added this to the7.2 milestoneJul 25, 2024
@alexandre-dauboisalexandre-daubois changed the base branch from7.2 to5.4July 25, 2024 09:59
@derrabusderrabus modified the milestones:7.2,5.4Jul 25, 2024
Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks like we need to do something about cases wheresetCsvControl() is never called (see the failing tests)

alexandre-daubois reacted with eyes emoji
@alexandre-daubois
Copy link
MemberAuthor

Indeed. All green now 👍

@nicolas-grekas
Copy link
Member

Thank you@alexandre-daubois.

@nicolas-grekasnicolas-grekas merged commit31e3abf intosymfony:5.4Jul 26, 2024
This was referencedJul 26, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@xabbuhxabbuhxabbuh approved these changes

@welcoMatticwelcoMatticAwaiting requested review from welcoMattic

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@alexandre-daubois@carsonbot@nicolas-grekas@xabbuh@derrabus
[8]ページ先頭
©2009-2025 Movatter.jp