Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer][Translation] Deprecate passing a non-empty CSV escape char#57827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.2fromalexandre-daubois:deprec-csv-escape
Aug 19, 2024

Conversation

@alexandre-daubois
Copy link
Member

QA
Branch?7.2
Bug fix?no
New feature?no
Deprecations?yes
Issues-
LicenseMIT

Using a non-empty string for CSV escape charwill be deprecated in 8.4. Let's deprecate where relevant in the codebase?

@carsonbotcarsonbot added this to the7.2 milestoneJul 25, 2024
nicolas-grekas added a commit that referenced this pull requestJul 26, 2024
…P >= 7.4 (alexandre-daubois)This PR was merged into the 5.4 branch.Discussion----------[Translation] Fix CSV escape char in `CsvFileLoader` on PHP >= 7.4| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITRelated to#57827. This check has already been done in other places like:https://github.com/symfony/symfony/blob/4a176ceb4b67d1f17cdfb88ecc0946e47a807f65/src/Symfony/Component/DependencyInjection/EnvVarProcessor.php#L310Commits-------0507c22 [Translation] Fix CSV escape char in `CsvFileLoader` on PHP >= 7.4
@alexandre-daubois
Copy link
MemberAuthor

For the record, the deprecation poll is closed and it has been confirmed for 8.4:https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_proprietary_csv_escaping_mechanism

@alexandre-dauboisalexandre-dauboisforce-pushed thedeprec-csv-escape branch 3 times, most recently from5dc0f15 to9515a39CompareAugust 13, 2024 14:59
@fabpot
Copy link
Member

Thank you@alexandre-daubois.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@mtarldmtarldmtarld requested changes

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@welcoMatticwelcoMatticAwaiting requested review from welcoMatticwelcoMattic is a code owner

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

7.2

Development

Successfully merging this pull request may close these issues.

6 participants

@alexandre-daubois@fabpot@nicolas-grekas@stof@mtarld@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp