NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Validator] treat uninitialized properties referenced by property paths as null#57812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromxabbuh:issue-46347

Jul 26, 2024

Merged

[Validator] treat uninitialized properties referenced by property paths as null#57812

nicolas-grekas merged 1 commit intosymfony:5.4fromxabbuh:issue-46347

Jul 26, 2024

Conversation

Copy link

Member

xabbuh commentedJul 24, 2024

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix#46347
License	MIT

carsonbot added Status: Needs Review Bug Validator labels

Jul 24, 2024

carsonbot added this to the5.4 milestone

Jul 24, 2024

xabbuh mentioned this pull request

Jul 24, 2024

[Validator] Cannot usepropertyPath with uninitialized properties#46347

Closed

xabbuh force-pushed theissue-46347 branch fromb23f0b8 toc920ea0Compare

July 24, 2024 07:10

alexandre-daubois reviewed

Jul 24, 2024

View reviewed changes

src/Symfony/Component/Validator/Tests/Constraints/BicValidatorTest.php OutdatedShow resolvedHide resolved

alexandre-daubois reviewed

Jul 24, 2024

View reviewed changes

src/Symfony/Component/Validator/Tests/Constraints/RangeValidatorTest.php OutdatedShow resolvedHide resolved

xabbuh force-pushed theissue-46347 branch 2 times, most recently from6445055 to020b35aCompare

July 24, 2024 07:39

alexandre-daubois approved these changes

Jul 24, 2024

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jul 24, 2024

xabbuh force-pushed theissue-46347 branch 3 times, most recently fromfdc844f to2a3a91eCompare

July 24, 2024 13:46

yceruto approved these changes

Jul 24, 2024

View reviewed changes

xabbuh mentioned this pull request

Jul 25, 2024

[Validator] properly set up constraint options#57823

Merged

nicolas-grekas added a commit that referenced this pull request

Jul 26, 2024

minor#57823[Validator] properly set up constraint options (xabbuh)

e507619

This PR was merged into the 5.4 branch.Discussion----------[Validator] properly set up constraint options| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        || License       | MITwhile working on#57812 I noticed that we did not properly set up some of the constraints which means that tests making use of constraint options were never tested correctlyCommits-------a3e0dc9 properly set up constraint options