Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Deprecatesession.sid_length andsession.sid_bits_per_character config options#57805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-dauboisalexandre-daubois commentedJul 23, 2024•
edited
Loading

QA
Branch?7.2
Bug fix?no
New feature?no
Deprecations?yes
Issues-
LicenseMIT

These options are (very) likely to bedeprecated in PHP 8.4. Because of the many reasons of their deprecation, they may be deprecated in Symfony as well starting the next version.

@alexandre-daubois
Copy link
MemberAuthor

For the record, the deprecation poll is closed and it has been confirmed for 8.4:https://wiki.php.net/rfc/deprecations_php_8_4#sessionsid_length_and_sessionsid_bits_per_character

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedAug 13, 2024•
edited
Loading

NativeSessionStorage also has references to these ini options. Can you please have a look and advise what we should do there?

alexandre-daubois reacted with eyes emoji

@stof
Copy link
Member

NativeSessionStorage should also trigger a deprecation when those options are passed (not just FrameworkBundle)

alexandre-daubois reacted with thumbs up emoji

@alexandre-daubois
Copy link
MemberAuthor

PR updated so NativeSessionStorage also throws a deprecation warning

@alexandre-dauboisalexandre-daubois changed the title[FrameworkBundle] Deprecatesession.sid_length andsession.sid_bits_per_character config options[FrameworkBundle][HttpFoundation] Deprecatesession.sid_length andsession.sid_bits_per_character config optionsAug 19, 2024
@alexandre-dauboisalexandre-dauboisforce-pushed thesession-deprecs branch 3 times, most recently from72c6f7e toe31686dCompareAugust 27, 2024 12:50
@carsonbotcarsonbot changed the title[FrameworkBundle][HttpFoundation] Deprecatesession.sid_length andsession.sid_bits_per_character config options[FrameworkBundle] Deprecatesession.sid_length andsession.sid_bits_per_character config optionsAug 29, 2024
@alexandre-daubois
Copy link
MemberAuthor

Rebased after the merge of#58244

javiereguiluz reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

Thank you@alexandre-daubois.

@nicolas-grekasnicolas-grekas merged commitf91514d intosymfony:7.2Sep 16, 2024
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestSep 17, 2024
…_length` and `session.sid_bits_per_character` config options (alexandre-daubois)This PR was merged into the 7.2 branch.Discussion----------[FrameworkBundle][HttpFoundation] Deprecate `session.sid_length` and `session.sid_bits_per_character` config optionsRelated tosymfony/symfony#57805Fixes#20224Commits-------f39be76 [FrameworkBundle][HttpFoundation] Deprecate `session.sid_length` and `session.sid_bits_per_character` config options
@fabpotfabpot mentioned this pull requestOct 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

+1 more reviewer

@rosierrosierrosier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

7.2

Development

Successfully merging this pull request may close these issues.

7 participants

@alexandre-daubois@nicolas-grekas@stof@javiereguiluz@rosier@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp