Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] Update web-token/jwt-library version and adjust checker parameters#57796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

thibaut22200
Copy link
Contributor

@thibaut22200thibaut22200 commentedJul 22, 2024•
edited
Loading

QA
Branch?7.1
Bug fix?no
LicenseMIT

Test failed on my Ubuntu, and on my Windows is OK. Differences between order in construct of Jose/Component/Checker/...

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.1 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the titleStrange behavior for OidcTokenHandler[Security] Strange behavior for OidcTokenHandlerJul 22, 2024
@xabbuh
Copy link
Member

Maybe we should backport#57694. In tests we don't use version 4 of web-token/jwt-library, but since we don't have a conflict rule for it consumers of symfony/security-http can use it and run into the issue this PR is going to fix.

@OskarStarkOskarStark changed the title[Security] Strange behavior for OidcTokenHandler[Security] Strange behavior forOidcTokenHandlerJul 22, 2024
@nicolas-grekas
Copy link
Member

Better back port than conflict to me also.

@thibaut22200
Copy link
ContributorAuthor

Backport commit done@xabbuh@nicolas-grekas

@thibaut22200thibaut22200 changed the title[Security] Strange behavior forOidcTokenHandler[SecurityBundle] Update web-token/jwt-library version and adjust checker parametersJul 24, 2024
@carsonbotcarsonbot changed the title[SecurityBundle] Update web-token/jwt-library version and adjust checker parameters[Security] Update web-token/jwt-library version and adjust checker parametersJul 24, 2024
@thibaut22200thibaut22200force-pushed theoidc-token-handler-diff-for-checkers branch fromf1e656d toe8ea16bCompareJuly 24, 2024 13:58
Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks like changes from#57767 slipped into this PR

@thibaut22200thibaut22200force-pushed theoidc-token-handler-diff-for-checkers branch 2 times, most recently fromb349c2e to6009932CompareJuly 25, 2024 08:52
@thibaut22200
Copy link
ContributorAuthor

Oops, fixed@xabbuh

@fabpotfabpotforce-pushed theoidc-token-handler-diff-for-checkers branch from6009932 to536cd72CompareJuly 26, 2024 07:24
@fabpot
Copy link
Member

Thank you@thibaut22200.

@fabpotfabpot merged commitc2bafcd intosymfony:7.1Jul 26, 2024
1 check was pending
@thibaut22200thibaut22200 deleted the oidc-token-handler-diff-for-checkers branchJuly 26, 2024 12:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@xabbuhxabbuhxabbuh approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

5 participants
@thibaut22200@carsonbot@xabbuh@nicolas-grekas@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp