NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Security] pass the current token to the`checkPostAuth()` method of user checkers#57773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:7.2fromxabbuh:issue-50650

Jul 25, 2024

Merged

[Security] pass the current token to the`checkPostAuth()` method of user checkers#57773

fabpot merged 1 commit intosymfony:7.2fromxabbuh:issue-50650

Jul 25, 2024

Conversation

Copy link

Member

xabbuh commentedJul 19, 2024

Q	A
Branch?	7.2
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	Fix#50650
License	MIT

xabbuh requested a review fromchalasr as acode owner

July 19, 2024 07:47

carsonbot added Status: Needs Review Feature Security labels

Jul 19, 2024

carsonbot added this to the7.2 milestone

Jul 19, 2024

xabbuh mentioned this pull request

Jul 19, 2024

[security] Provide authentification token when using an user checker#50650

Closed

alexandre-daubois reviewed

Jul 19, 2024

View reviewed changes

src/Symfony/Component/Security/Core/User/ChainUserChecker.php OutdatedShow resolvedHide resolved

xabbuh force-pushed theissue-50650 branch frome1bd3ad to7ee12daCompare

July 19, 2024 09:20

AlexisRossat reviewed

Jul 19, 2024

View reviewed changes

src/Symfony/Component/Security/Core/User/ChainUserChecker.phpShow resolvedHide resolved

Copy link

Member

chalasr commentedJul 19, 2024

👍 some testcase would be nice to have though

xabbuh force-pushed theissue-50650 branch from7ee12da todd958fdCompare

July 19, 2024 12:11

pass the current token to the checkPostAuth() method of user checkers

35b97b9

xabbuh force-pushed theissue-50650 branch fromdd958fd to35b97b9Compare

July 19, 2024 12:12

Copy link

MemberAuthor

xabbuh commentedJul 19, 2024

tests added

xabbuh force-pushed theissue-50650 branch fromdf4b23d to35b97b9Compare

July 19, 2024 13:17

chalasr approved these changes

Jul 20, 2024

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jul 20, 2024

OskarStark changed the title~~[Security] pass the current token to the checkPostAuth() method of user checkers~~[Security] pass the current token to thecheckPostAuth() method of user checkers

Jul 22, 2024

fabpot approved these changes

Jul 25, 2024

View reviewed changes

Copy link

Member

fabpot commentedJul 25, 2024

Thank you@xabbuh.

fabpot merged commit6c7a6ff intosymfony:7.2

Jul 25, 2024

fabpot mentioned this pull request

Jul 25, 2024

[Security] pass the current token to thecheckPostAuth() method of us…symfony/symfony-docs#20062

Closed

xabbuh deleted the issue-50650 branch

July 25, 2024 07:02

fabpot mentioned this pull request

Oct 27, 2024

Release v7.2.0-BETA1#58686

Merged

nicolas-grekas mentioned this pull request

Jul 22, 2025

[Security] Fix added $token argument to UserCheckerInterface::checkPostAuth()#61194

Merged

nicolas-grekas added a commit that referenced this pull request

Jul 22, 2025

bug#61194[Security] Fix added $token argument to UserCheckerInterfa…

dabfa59

…ce::checkPostAuth() (nicolas-grekas)This PR was merged into the 7.2 branch.Discussion----------[Security] Fix added $token argument to UserCheckerInterface::checkPostAuth()| Q             | A| ------------- | ---| Branch?       | 7.2| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITAn added argument must be optional and must be declared using ``@param``, which will allow spotting all places that have to be updated in cascade. This PR fixes all that. Not sure how we messed up so badly in#57773 😅Commits-------c819110 [Security] Fix added $token argument to UserCheckerInterface::checkPostAuth()