Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[SecurityBundle] use firewall-specific user checkers when manually logging in users#57748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedJul 17, 2024
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix#57706 |
| License | MIT |
chalasr commentedJul 18, 2024
Supersedes#54287 I think. |
chalasr commentedJul 22, 2024
Thank you@xabbuh. |
faizanakram99 commentedJul 29, 2024
@xabbuh this is a breaking change, earlier user checkers were not called for programmatic logins, now they're. This has been working like this for a number of years and now the behaviour changed. |
chalasr commentedJul 29, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@faizanakram99 every bugfix breaks code that adapted itself to work with the bug. Defining a custom user checker implies that it replaces the default one but in this case the custom one was ignored, that is a bug. |
94noni commentedAug 7, 2024
just to comment that this properly addresses my original issue, calling the login user checker accordingly, thx@xabbuh and@chalasr @faizanakram99 sad to hear that this break yours, can you detail your workflow of "security check" ? perhaps there is something different that may be done to satisfy both worlds |
faizanakram99 commentedAug 7, 2024
@94noni We were relying on the behaviour which was changed here and our tests broke all of sudden after upgrade, took me a while to figure this out. We adjusted it already with the new changes, thanks. |