Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

do not useuniqid() for generating dev tool tokens#57746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:7.2fromxabbuh:issue-57588
Jul 18, 2024

Conversation

@xabbuh
Copy link
Member

QA
Branch?7.2
Bug fix?no
New feature?no
Deprecations?no
Issuespart of#57588
LicenseMIT

GromNaN reacted with thumbs up emoji
Copy link
Member

@alexandre-dauboisalexandre-daubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice!

@OskarStarkOskarStark changed the titledo not use uniqid() for generating dev tool tokensdo not useuniqid() for generating dev tool tokensJul 17, 2024
@derrabus
Copy link
Member

How important is it to havecollision-free tokens? I mean, the places where we've cut six characters out of a hash were certainly not collision-free, butTraceableSerializer used the (allegedly) collision-freeuniqid() directly.

@xabbuh
Copy link
MemberAuthor

We could increase the length of the generated string. What do you think about that?

GromNaN reacted with thumbs up emoji

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's go with 4 bytes then?

derrabus reacted with thumbs up emoji
@xabbuh
Copy link
MemberAuthor

updated for four random bytes

@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

@nicolas-grekasnicolas-grekas merged commit9a02660 intosymfony:7.2Jul 18, 2024
@xabbuhxabbuh deleted the issue-57588 branchJuly 18, 2024 09:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@GromNaNGromNaNGromNaN approved these changes

@alexandre-dauboisalexandre-dauboisalexandre-daubois approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

7.2

Development

Successfully merging this pull request may close these issues.

6 participants

@xabbuh@derrabus@nicolas-grekas@GromNaN@alexandre-daubois@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp