Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Add theWordCount constraint#57716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xabbuh merged 1 commit intosymfony:7.2fromalexandre-daubois:word-count
Jul 17, 2024

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-dauboisalexandre-daubois commentedJul 12, 2024•
edited
Loading

QA
Branch?7.2
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#6813
LicenseMIT

Doc PR:symfony/symfony-docs#20047

SVillette, damienalexandre, and Korbeil reacted with thumbs up emojiahmedyakoubi reacted with heart emoji
yield ['', 1]; // empty string should always pass and eventually be handled by NotBlankValidator
}

public static function provideInvalidTypes()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
publicstaticfunction provideInvalidTypes()
publicstaticfunction provideInvalidTypes():iterable

derrabus and erkanzsy reacted with thumbs up emoji
@alexandre-daubois
Copy link
MemberAuthor

Pushed plural form of the constraint message

Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

the failures on AppVeyor look related, we need to skip some of the added tests when the intl extension is missing

@alexandre-daubois
Copy link
MemberAuthor

Thought of adding a check in the constraint but forgot the tests. Thanks for pointing out, I added@requires

xabbuh reacted with thumbs up emoji

@OskarStark
Copy link
Contributor

Can you please create and reference a docs PR? Thanks

alexandre-daubois reacted with thumbs up emoji

@alexandre-daubois
Copy link
MemberAuthor

alexandre-daubois commentedJul 17, 2024•
edited
Loading

@OskarStark of course, here you go:symfony/symfony-docs#20047

@xabbuh
Copy link
Member

Thank you@alexandre-daubois.

@xabbuhxabbuh merged commite63495e intosymfony:7.2Jul 17, 2024
fabpot added a commit that referenced this pull requestJul 17, 2024
…raint (OskarStark)This PR was squashed before being merged into the 5.4 branch.Discussion----------[Validator] Add German translation for `WordCount` constraint| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        || License       | MITNeeds*#57716Commits-------b0eaf91 [Validator] Add German translation for `WordCount` constraint
fabpot added a commit that referenced this pull requestJul 17, 2024
…n (alexandre-daubois)This PR was merged into the 5.4 branch.Discussion----------[Validator] Add `WordCount` constraint French translation| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        | -| License       | MIT:information_source: Requires#57716 to be merged firstCommits-------bd98f5d [Validator] Add `WordCount` constraint French translation
nicolas-grekas added a commit that referenced this pull requestJul 18, 2024
This PR was merged into the 7.2 branch.Discussion----------[Validator] Unwrap useless cast| Q             | A| ------------- | ---| Branch?       | 7.2| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITAfter `@AlexisRossat`'s [comment](#57716 (comment)), the same cast was found at some other places in Validator.Commits-------15dc8bd [Validator] Unwrap useless cast
symfony-splitter pushed a commit to symfony/validator that referenced this pull requestJul 18, 2024
This PR was merged into the 7.2 branch.Discussion----------[Validator] Unwrap useless cast| Q             | A| ------------- | ---| Branch?       | 7.2| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITAfter `@AlexisRossat`'s [comment](symfony/symfony#57716 (comment)), the same cast was found at some other places in Validator.Commits-------15dc8bd780 [Validator] Unwrap useless cast
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestJul 19, 2024
…ubois)This PR was merged into the 7.2 branch.Discussion----------[Validator] Add the `WordCount` constraintRelated tosymfony/symfony#57716Commits-------e983455 [Validator] Add the `WordCount` constraint
@fabpotfabpot mentioned this pull requestOct 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@derrabusderrabusderrabus approved these changes

@xabbuhxabbuhxabbuh approved these changes

+1 more reviewer

@AlexisRossatAlexisRossatAlexisRossat left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

7.2

Development

Successfully merging this pull request may close these issues.

[RFC] [Validator] adding a new WordCount constraint validator

6 participants

@alexandre-daubois@OskarStark@xabbuh@derrabus@AlexisRossat@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp