Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
use more entropy with uniqid()#57697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedJul 10, 2024
Thank you@xabbuh. |
This PR was merged into the 6.4 branch.Discussion----------use more entropy with `uniqid()`| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | no| New feature? | no| Deprecations? | no| Issues || License | MITfollowing#57697 on the `6.4` branchCommits-------b91e8a2 use more entropy with uniqid()
natewiebe13 commentedJul 15, 2024
@xabbuh just an observation; looking back at the linked PRs, the original motivation appears to be an optimization as PHP used to skip the Ref:https://github.com/php/php-src/blob/master/ext/standard/uniqid.c |
xabbuh commentedJul 17, 2024
@natewiebe13 Thank you for the hint. I wasn't aware of it, but this was indeed improved inphp/php-src@d25049c. |
It looked like using
uniqid()without opting for more entropy slipped in after#20132 and#20137.