NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[WebProfilerBundle] Change incorrect check for the`stateless` request attribute#57679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.4fromthemasch:patch-1

Jul 9, 2024

Merged

[WebProfilerBundle] Change incorrect check for the`stateless` request attribute#57679

nicolas-grekas merged 1 commit intosymfony:6.4fromthemasch:patch-1

Jul 9, 2024

Conversation

Copy link

Contributor

themasch commentedJul 8, 2024

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues
License	MIT

When upgrading our project from 5.4 to 6.4 (yep..we're late) we encountered an "Session was used while the request was declared stateless." exception when opening the profiler. Ourmain firewall setsstateless: true as its only used for API requests (and the profiler). Debugging to find what caused the session to be initialized I ended up in theProfilerController::searchBarAction, which gets the sessiononly if the_stateless attribute istrue.

According to my understanding an the discussion herehttps://github.com/symfony/symfony/pull/50218/files#r1668401248 this seems to be incorrect.

We only want to use the session if the request isnotstateless.

Change incorrect check for thestateless request attribute

92093b9

We only want to use the session if the request is **not** `stateless`. The old code used the sesison only in `stateless` requests (so requests not intended to use the session (=state) at all).

carsonbot added Status: Needs Review Bug labels

Jul 8, 2024

carsonbot added this to the6.4 milestone

Jul 8, 2024

Copy link

carsonbot commentedJul 8, 2024

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

themasch mentioned this pull request

Jul 8, 2024

Profiler respect stateless attribute#50218

Merged

xabbuh approved these changes

Jul 8, 2024

View reviewed changes

Copy link

Member

xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jul 8, 2024

OskarStark added the WebProfilerBundle label

Jul 8, 2024

carsonbot changed the title~~Change incorrect check for thestateless request attribute~~[WebProfilerBundle] Change incorrect check for thestateless request attribute

Jul 8, 2024