Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PropertyInfo] AddPropertyDescriptionExtractorInterface toPhpStanExtractor#57632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:7.3frommtarld:feat/implement-property-description-extractorJan 5, 2025
Merged
[PropertyInfo] AddPropertyDescriptionExtractorInterface toPhpStanExtractor#57632
fabpot merged 1 commit intosymfony:7.3frommtarld:feat/implement-property-description-extractorJan 5, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
8348a29 to833c6ebComparechalasr approved these changesDec 10, 2024
b256783 toca2e1c9CompareMember
xabbuh commentedDec 18, 2024
@mtarld Can you rebase? |
ca2e1c9 tobd80f29Comparefabpot approved these changesJan 5, 2025
Member
fabpot commentedJan 5, 2025
Thank you@mtarld. |
f86c095 intosymfony:7.3 10 of 11 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in#40457, the
PhpStanExtractorshould at some point implement thePropertyDescriptionExtractorInterface.This PR adds that implementation.