Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[String] test: kebab-case to snake_case#57628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromwmouwen:test/kebab-case-to-snake-case
Jul 6, 2024

Conversation

@wmouwen
Copy link
Contributor

@wmouwenwmouwen commentedJul 2, 2024•
edited
Loading

QA
Branch?5.4
Bug fix?yes?
New feature?no
Deprecations?no
Issues-
LicenseMIT

In Symfony 7.1.1,kebab-case strings casted tosnake_case properly. The changes made in 7.1.2 broke this functionality and kept itkebab-case.

It would be nice to have akebab-case test added to the list to clearly define the expected behavior.

Relates to:#57497,#57612,#57616

Amirhf1 reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

wmouwen reacted with thumbs up emoji

@carsonbot

This comment was marked as outdated.

@wmouwenwmouwen changed the base branch from7.2 to7.1July 2, 2024 19:30
@OskarStarkOskarStark modified the milestones:7.2,7.1Jul 3, 2024
@wmouwenwmouwenforce-pushed thetest/kebab-case-to-snake-case branch from1bf9a5f toa824811CompareJuly 5, 2024 17:26
@wmouwenwmouwenforce-pushed thetest/kebab-case-to-snake-case branch froma824811 toa6d0f3bCompareJuly 5, 2024 17:27
@wmouwenwmouwen changed the base branch from7.1 to5.4July 5, 2024 17:28
@wmouwen
Copy link
ContributorAuthor

Included the testcase suggested by@xabbuh.

Rebased against and retargeted PR to Symfony 5.4 instead of 7.1.

@fabpot
Copy link
Member

Thank you@wmouwen.

@fabpotfabpot merged commit737d519 intosymfony:5.4Jul 6, 2024
@wmouwenwmouwen deleted the test/kebab-case-to-snake-case branchJuly 6, 2024 10:57
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@wmouwen@carsonbot@fabpot@xabbuh@OskarStark
[8]ページ先頭
©2009-2025 Movatter.jp