Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[String] Revert "Fixed u()->snake(), b()->snake() and s()->snake() methods"#57616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromnicolas-grekas:string-inflection
Jul 1, 2024

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#57612
LicenseMIT

This PR reverts#57497 for BC reasons, but keeps the test cases we added in the process. Those test cases allowed to spot a real issue where the ascii and unicode implementations didn't agree on the resulting camel case forSYMFONY IS GREAT. Both implementations now result inSYMFONYISGREAT (likely introduced in#47423).

@carsonbotcarsonbot added this to the5.4 milestoneJul 1, 2024
@nicolas-grekasnicolas-grekas changed the titleString inflection[String] Revert "Fixed u()->snake(), b()->snake() and s()->snake() methods (arczinosek)"Jul 1, 2024
@nicolas-grekasnicolas-grekas changed the title[String] Revert "Fixed u()->snake(), b()->snake() and s()->snake() methods (arczinosek)"[String] Revert "Fixed u()->snake(), b()->snake() and s()->snake() methods"Jul 1, 2024
@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commite3625f2 intosymfony:5.4Jul 1, 2024
fabpot added a commit that referenced this pull requestJul 6, 2024
This PR was merged into the 5.4 branch.Discussion----------[String] test: kebab-case to snake_case| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes?| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITIn Symfony 7.1.1, `kebab-case` strings casted to `snake_case` properly. The changes made in 7.1.2 broke this functionality and kept it `kebab-case`.It would be nice to have a `kebab-case` test added to the list to clearly define the expected behavior.Relates to:#57497,#57612,#57616Commits-------a6d0f3b test: kebab-case to snake_case
@nicolas-grekasnicolas-grekas deleted the string-inflection branchJuly 18, 2024 08:41
@kevinpapst
Copy link

This is still not correct or at least contains a BC break@nicolas-grekas

I did not check whether this was introduced by the original change or your fix.

The string123-customer,with/special#name was previously (for years) converted to123-customer_with_special_name.
Now it returns123-customer,with/special#name, so many characters are not converted as expected.

New bug report?

@nicolas-grekas
Copy link
MemberAuthor

Better: a PR! 🙏

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@fabpot@kevinpapst@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp