Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[TwigBridge] Use constant var name to cachetrans_default_domain
expression result#57609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
trans_default_domain
expression resulttrans_default_domain
expression resultThank you@GromNaN. |
68a5704
intosymfony:7.2Uh oh!
There was an error while loading.Please reload this page.
stof commentedOct 25, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Using a fixed variable name is actually broken. The Twig scope is shared with all the inheritance tree of templates, so wedo have multiple names per scope (as |
… default domain node visitor (xabbuh)This PR was merged into the 7.2 branch.Discussion----------[TwigBridge] use reproducible variable names in the default domain node visitor| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | yes| Deprecations? | no| Issues |Fixsymfony#57609 (comment)| License | MITCommits-------500d72f use reproducible variable names in the default domain node visitor
Uh oh!
There was an error while loading.Please reload this page.
When
trans_default_domain
is used with an expression, the result of the expression is cached into a variable and this variable is stored in theScope
to be used for each following usage of the|trans
filter.This var name doesn't need to be random:
trans_default_domain
is called a second time, the same variable can be reassigned.The only benefit of using a random var name would be to prevent usage in the template. The name
__internal_trans_default_domain
self-explains that it is not meant to be used.