Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[String] Normalize underscores in snake()#57594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromxabbuh:pr-57497
Jun 29, 2024

Conversation

@xabbuh
Copy link
Member

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#57497 (comment)
LicenseMIT

@carsonbotcarsonbot added this to the5.4 milestoneJun 29, 2024
@carsonbotcarsonbot changed the title[String] normalize underscores in snake()[String]  normalize underscores in snake()Jun 29, 2024
['symfony_is_great','SYMFONY IS GREAT'],
['symfony_is_great','SYMFONY_IS_GREAT'],
['symfony_is_great','symfony is great'],
['symfony_is_great','SYMFONY IS GREAT'],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

can you please add a test case like
['symfony_is_great', 'SYMFONY _ IS _ GREAT'],

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

done, and this also revealed a bug in my patch

@nicolas-grekasnicolas-grekas changed the title[String]  normalize underscores in snake()[String] Normalize underscores in snake()Jun 29, 2024
@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@xabbuh@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp