Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpKernel] Compare paths after realpath() has been applied to both#57593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@xabbuh
Copy link
Member

@xabbuhxabbuh commentedJun 29, 2024
edited
Loading

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
Issues
LicenseMIT

@xabbuh
Copy link
MemberAuthor

xabbuh commentedJun 29, 2024
edited
Loading

This does not look like the right solution. The tests used to work before#57553 without the files being present.

@xabbuhxabbuh closed thisJun 29, 2024
@xabbuhxabbuh deleted the security-bundle-functional-tests branchJune 29, 2024 04:14
@xabbuhxabbuh restored the security-bundle-functional-tests branchJune 29, 2024 04:19
@xabbuhxabbuh reopened thisJun 29, 2024
@xabbuhxabbuhforce-pushed thesecurity-bundle-functional-tests branch frome6479ea toebff9edCompareJune 29, 2024 04:23
@xabbuhxabbuh changed the title[SecurityBundle] add missing routing configs[FrameworkBundle][SecurityBundle] add missing routing configs in functional testsJun 29, 2024
@nicolas-grekas
Copy link
Member

nicolas-grekas commentedJun 29, 2024
edited
Loading

The issue is only on appveyor right?
Then here is why: before#57553, the router cache warmer wasn't triggered, and since routes where never used by these test cases, we didn't need these yaml files. It looks like on Windows, we take the$cacheDir !== $buildDir codepath and we enable the optional cache warmers.
I think we should figure out why these paths are different on Windows and fix that part.
The fact that these yaml files are missing is actually a good thing: it proves that we didn't run any logic to care about routes while routes are unused, which is good for the perf of tests.

@xabbuh
Copy link
MemberAuthor

The issue is only on appveyor right?

I can observe the same behaviour locally. I will investigate a bit more.

nicolas-grekas reacted with thumbs up emoji

@xabbuhxabbuhforce-pushed thesecurity-bundle-functional-tests branch fromebff9ed tod58faccCompareJune 29, 2024 06:54
@xabbuhxabbuh changed the title[FrameworkBundle][SecurityBundle] add missing routing configs in functional tests[FrameworkBundle][SecurityBundle] Compare paths after realpath() has been applied to bothJun 29, 2024
@xabbuhxabbuhforce-pushed thesecurity-bundle-functional-tests branch fromd58facc to7e0993dCompareJune 29, 2024 07:06
@carsonbotcarsonbot changed the title[FrameworkBundle][SecurityBundle] Compare paths after realpath() has been applied to both[SecurityBundle] Compare paths after realpath() has been applied to bothJun 29, 2024
@xabbuhxabbuhforce-pushed thesecurity-bundle-functional-tests branch from7e0993d to6ca2390CompareJune 29, 2024 09:25
@chalasr
Copy link
Member

Thank you@xabbuh.

@chalasrchalasr merged commit4a48cfe intosymfony:6.4Jun 29, 2024
@xabbuhxabbuh deleted the security-bundle-functional-tests branchJune 29, 2024 09:50
@carsonbotcarsonbot changed the title[SecurityBundle] Compare paths after realpath() has been applied to both[HttpKernel] Compare paths after realpath() has been applied to bothJul 5, 2024
This was referencedJul 26, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

4 participants

@xabbuh@nicolas-grekas@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp