Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpFoundation] Fix MockArraySessionStorage to generate more conform ids#57585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromSeldaek:patch-33
Jun 29, 2024

Conversation

@Seldaek
Copy link
Member

@SeldaekSeldaek commentedJun 28, 2024
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Issues
LicenseMIT

Perhttps://wiki.php.net/rfc/deprecations_php_8_4#sessionsid_length_and_sessionsid_bits_per_character the session id really shouldn't need more than 128bits of entropy, which this PR uses. While this code indeed does not need cryptographically secure level of entropy, it also doesn't really cost that much so I did it this way, as it's IMO good to avoid having cryptographically-insecure code out there where people might take inspiration from it.

As an aside, uniqid might also end up being deprecated, so it's good to get rid of it anyway herehttps://wiki.php.net/rfc/deprecations_php_8_4#deprecate_uniqid

And as another aside, I've had to override this code in the past because we had DB tables storing session ids not accepting the 64chars long session ids the old code produces, so producing shorter (32chars) ids is more compatible 👍🏻

derrabus reacted with rocket emoji
@carsonbotcarsonbot added this to the5.4 milestoneJun 28, 2024
@carsonbotcarsonbot changed the titleFix MockArraySessionStorage to generate more conform ids[HttpFoundation] Fix MockArraySessionStorage to generate more conform idsJun 28, 2024
@nicolas-grekas
Copy link
Member

Related to#57588

@nicolas-grekas
Copy link
Member

Thank you@Seldaek.

@nicolas-grekasnicolas-grekas merged commit19b4bf0 intosymfony:5.4Jun 29, 2024
@SeldaekSeldaek deleted the patch-33 branchJuly 1, 2024 09:13
This was referencedJul 26, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@Seldaek@nicolas-grekas@xabbuh@OskarStark@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp