Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DependencyInjection] Fix ignore invalid_reference behavior param for the some services#57561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
vtsykun wants to merge1 commit intosymfony:5.4
base:5.4
Choose a base branch
Loading
fromvtsykun:fix/di-dumper
Open
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Di] Fix invalid reference behavior
  • Loading branch information
root committedJun 27, 2024
commit02f7ccdd3121c64b3112a2067e647734b7094f05
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1009,7 +1009,7 @@ private function addInlineReference(string $id, Definition $definition, string $
$name = $this->getNextVariableName();
$this->referenceVariables[$targetId] = new Variable($name);

$reference = ContainerInterface::EXCEPTION_ON_INVALID_REFERENCE>= $behavior ? new Reference($targetId, $behavior) : null;
$reference = ContainerInterface::EXCEPTION_ON_INVALID_REFERENCE!== $behavior ? new Reference($targetId, $behavior) : null;
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Perhaps, there was just a typo here and the author meant$behavior >= ContainerInterface::EXCEPTION_ON_INVALID_REFERENCE.

The bug was hidden for a long time because it can only be reproduced for "synthetic" services likekernel and in specific cases. But the other services replaced by null on optimization step before

$code .= sprintf(" \$%s = %s;\n", $name, $this->getServiceCall($targetId, $reference));

if (!$hasSelfRef || !$forConstructor) {
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp