Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer][RFC] recursive object normalizer#57547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
idbentley wants to merge2 commits intosymfony:7.4
base:7.4
Choose a base branch
Loading
fromidbentley:feat/consistent-object-normalization

Conversation

idbentley
Copy link

QA
Branch?7.2
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix 57546...
LicenseMIT

This pull request introduces a new optional flag for theObjectNormalizer which causes it to behave in a more consistent way, using recursive calls to the user provided Normalizers, rather than using the alternative implementations provided in theAbstractObjectNormalizer. In this mode, the user may be required to provide additional Normalizers than they would have needed to with the inconsistent current behaviour, but those additional Normalizers should not effect the behaviour of existing usages.

This pull request is incomplete - as I am requesting feedback on the approach that I'm taking.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the titleDRAFT/Request for feedback: recursive object normalizer[Serializer] DRAFT/Request for feedback: recursive object normalizerJun 27, 2024
@OskarStarkOskarStark changed the title[Serializer] DRAFT/Request for feedback: recursive object normalizer[Serializer] recursive object normalizerJun 27, 2024
@OskarStarkOskarStark added the RFCRFC = Request For Comments (proposals about features that you want to be discussed) labelJun 27, 2024
@OskarStarkOskarStark changed the title[Serializer] recursive object normalizer[Serializer][RFC] recursive object normalizerJun 27, 2024
@fabpotfabpot modified the milestones:7.2,7.3Nov 20, 2024
@fabpotfabpot modified the milestones:7.3,7.4May 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees
No one assigned
Labels
BugRFCRFC = Request For Comments (proposals about features that you want to be discussed)SerializerStatus: Needs Review
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

4 participants
@idbentley@carsonbot@fabpot@OskarStark
[8]ページ先頭
©2009-2025 Movatter.jp