Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PropertyInfo] convert legacy types to TypeInfo types if getType() is not implemented#57459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xabbuh merged 1 commit intosymfony:7.1fromxabbuh:issue-57360
Jan 18, 2025

Conversation

xabbuh
Copy link
Member

QA
Branch?7.1
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#57360
LicenseMIT

neilime and phansys reacted with thumbs up emojillupa, ToshY, and priyadi reacted with eyes emoji
@xabbuh
Copy link
MemberAuthor

@hantsy FYI, if you would like to try this with your application

@stof
Copy link
Member

btw, the testsuite should probably have a legacy test covering the usage of a legacy extractor (not implementing the new method) inside those.

Copy link
Member

@stofstof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add tests covering this BC layer

@xabbuhxabbuhforce-pushed theissue-57360 branch 2 times, most recently frome2a595a toc8c4b55CompareJune 20, 2024 06:12
@xabbuh
Copy link
MemberAuthor

I have added some tests for this fix

@xabbuhxabbuhforce-pushed theissue-57360 branch 2 times, most recently from76bcfb5 to92a89bcCompareJune 22, 2024 05:05
@xabbuhxabbuhforce-pushed theissue-57360 branch 2 times, most recently from309d2c1 to835af97CompareJuly 1, 2024 09:57
@xabbuh
Copy link
MemberAuthor

Status: Needs Review

@ToshY
Copy link
Contributor

@stof Could you spare some time to re-review this?

@xabbuhxabbuh merged commitbfe7569 intosymfony:7.1Jan 18, 2025
10 of 11 checks passed
@xabbuhxabbuh deleted the issue-57360 branchJanuary 18, 2025 09:07
This was referencedJan 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@phansysphansysphansys approved these changes

@mtarldmtarldmtarld approved these changes

@chalasrchalasrchalasr approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

@stofstofAwaiting requested review from stof

Assignees
No one assigned
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

7 participants
@xabbuh@stof@ToshY@phansys@mtarld@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp