Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] [Lox24] Fix request body format to JSON string#57447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1fromalebedev80:7.1
Jun 19, 2024

Conversation

alebedev80
Copy link
Contributor

QA
Branch?7.1
Bug fix?yes
New feature?no
Deprecations?no
Issues
LicenseMIT

After lox24-notifier was release (version 7.1) i've found a bug. Request's headerContent-Type changed toapplication/x-www-form-urlencoded fromapplication\json.

Issue was relate to array type of the body. I've changed it to JSON string and tested. Looks good. Please merge.

Mohammadtrabelsi reacted with thumbs up emoji
@carsonbotcarsonbot added this to the7.1 milestoneJun 18, 2024
@carsonbotcarsonbot changed the titleFix request body format to JSON string[Notifier] Fix request body format to JSON stringJun 18, 2024
@OskarStarkOskarStark changed the title[Notifier] Fix request body format to JSON string[Notifier][Lox24] Fix request body format to JSON stringJun 19, 2024
@carsonbotcarsonbot changed the title[Notifier][Lox24] Fix request body format to JSON string[Notifier] [Lox24] Fix request body format to JSON stringJun 19, 2024
@fabpot
Copy link
Member

Thank you@alebedev80.

alebedev80 reacted with heart emoji

@fabpotfabpot merged commitdf9d96b intosymfony:7.1Jun 19, 2024
7 of 9 checks passed
@fabpotfabpot mentioned this pull requestJun 28, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@xabbuhxabbuhxabbuh left review comments

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

6 participants
@alebedev80@fabpot@OskarStark@xabbuh@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp