Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DependencyInjection] feat(env processor): add doc/help onAPP_SECRET env var not found exception#57422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
94noni wants to merge1 commit intosymfony:7.2from94noni:env-app-secret

Conversation

94noni
Copy link
Contributor

QA
Branch?7.2
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix inconsisteny that may occur when installing a deployment that needsAPP_SECRET env var that now may be undefined
LicenseMIT

Hey, I've followed recently the work on this topic, ref one of my try onrelated issue

I tend to agree that, just throwing an ex here can be problematic/inappropriate, mostly for newcomers that never have read a thing related to thisSymfony .env APP_SECRET

Here is one attempt to fill the comment#56985 (comment)

Friendly ping@javiereguiluz@nicolas-grekas do you have a better wording/phrasing and is it the best place?


For documentation inside the doc repo, I have no idea where to define such message, any idea ?
in the env config part? or in the vault part? elsewhere?
refsymfony/symfony-docs#19916

@carsonbotcarsonbot added this to the7.2 milestoneJun 17, 2024
@94noni94noni changed the titlefeat(env processor): add doc/help on env var missing exceptionfeat(env processor): add doc/help onAPP_SECRET env var missing exceptionJun 17, 2024
@94noni94noni changed the titlefeat(env processor): add doc/help onAPP_SECRET env var missing exceptionfeat(env processor): add doc/help onAPP_SECRET env var not found exceptionJun 17, 2024
@carsonbotcarsonbot changed the titlefeat(env processor): add doc/help onAPP_SECRET env var not found exception[DependencyInjection] feat(env processor): add doc/help onAPP_SECRET env var not found exceptionJun 17, 2024
@nicolas-grekas
Copy link
Member

👎 on my side, that's way too specific. I mentioned an approach that could work insymfony/recipes#1314 (comment), but we first need to be sure this needs to be improved. At the moment, the env var is needed only when activating one of the features listed in my comment there. A better place to tell about the feature could be in the documentation of those features.
Note thatfile_put_contents(".env", [...]) is putting a secret in a committed file. No-go :)

@94noni
Copy link
ContributorAuthor

thx for stopping here and commenting
indeed.env.local is more appropriate 😬

for the doc part, I tend to agree as well even if now I dont know were to document this specific use case
lets wait other ideas thanks :)

@nicolas-grekas
Copy link
Member

Closing as this approach is not the one we'll want to merge.
Thanks fur submitting.

94noni reacted with thumbs up emoji

@94noni94noni deleted the env-app-secret branchJune 21, 2024 14:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.

4 participants
@94noni@nicolas-grekas@OskarStark@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp