Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] [Console] added format parameter to ContainerDebugCommand#5740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
To make the output from the ContainerDebugCommand easier to parse, thispatch adds a `format` parameter to the command which defaults to`plain` (dumps the services like before). An additional `json` formatis implemented to dump the container info in json.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why removing the default value for$showPrivate ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
good catch, thanks!
fabpot commentedOct 13, 2012
I would like to come up with some standardization here as we already have a few commands that also support outputting in a different format (for instance the list command that can dump command in XML). |
fabpot commentedApr 20, 2013
Closing in favor of#7454 |
This PR was squashed before being merged into the master branch (closes#7454).Discussion----------[Console] application/command as text/xml/whatever decouplingThis PR removes description generation from `Command`, `Application` and `InputDefinition` classes and delegate it to specialized descriptor classes, making it dead simple to add new output formats.**Maybe this could include other commands, like `router:debug` or `container:debug` (see#5740)?**- [x] Add a `DescriptorProvider` which uses `DescriptorInterface` objects to describe things.- [x] Add `txt` descriptors.- [x] Add `xml` descriptors.- [x] Add `json` descriptors.- [x] Add `md` descriptors.- [x] Remove obsolete methods.- [x] Repair tests.| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#6339Commits-------51512e6 [Console] application/command as text/xml/whatever decoupling
Bug fix: [no]
Feature addition: [yes]
Backwards compatibility break: [no]
Symfony2 tests pass: [yes]
To make the output from the
ContainerDebugCommandeasier to parse, thispatch adds a
formatparameter to the command which defaults toplain(dumps the services like before). An additionaljsonformatis implemented to dump the container info in json.