Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HtmlSanitizer] Add support for configuring the default action#57399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.2fromSeldaek:sanitizer_default_action
Jun 29, 2024

Conversation

Seldaek
Copy link
Member

@SeldaekSeldaek commentedJun 14, 2024•
edited by OskarStark
Loading

QA
Branch?7.2
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#48358
LicenseMIT

The default action can be set to block or allow unconfigured elements instead of dropping them

Kinda replaces#49920 but it would need some work on the configuration handling side to allow configuring default actions. I am just using this as a library so I am not so keen on doing that part sorry but maybe@Neirda24 might want to take care of it if this PR gets accepted.

Neirda24 reacted with thumbs up emoji
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM but please mind the remaining minor comments.
Anyone up to do the remaining steps in FramewoorkBundle?

@Neirda24
Copy link
Contributor

LGTM but please mind the remaining minor comments. Anyone up to do the remaining steps in FramewoorkBundle?

Remaining steps would be to make this configuration available through the semantic configuration ? I'd be happy to try it out.

nicolas-grekas reacted with thumbs up emojinicolas-grekas reacted with heart emoji

@SeldaekSeldaekforce-pushed thesanitizer_default_action branch fromcf29db7 toa36fc54CompareJune 24, 2024 19:50
@Seldaek
Copy link
MemberAuthor

Alright I applied fixes for all feedback received.

@Neirda24 yes it would be making sure one can specify a default action in the sanitizer config in FrameworkBundle. Great if you can do that thanks!

…ck or allow unconfigured elements instead of dropping them
@SeldaekSeldaekforce-pushed thesanitizer_default_action branch froma36fc54 to4fd1c4cCompareJune 24, 2024 19:58
@fabpot
Copy link
Member

Thank you@Seldaek.

@fabpotfabpot merged commit98f511e intosymfony:7.2Jun 29, 2024
5 of 10 checks passed
@SeldaekSeldaek deleted the sanitizer_default_action branchJuly 3, 2024 09:42
@fabpotfabpot mentioned this pull requestOct 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@KocalKocalKocal left review comments

@Neirda24Neirda24Neirda24 left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.

[HtmlSanitizer] Add a blockAll helper
6 participants
@Seldaek@Neirda24@fabpot@nicolas-grekas@Kocal@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp