Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[PropertyInfo] Skip extractors that do not implementgetType#57363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
llupa commentedJun 10, 2024
| Q | A |
|---|---|
| Branch? | 7.1 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | yes |
| Issues | Fix#57360 |
| License | MIT |
I did not put any update on |
| if (!method_exists($extractor, $method)) { | ||
| trigger_deprecation('symfony/property-info', '7.1', 'Not implementing the "%s()" method in class "%s" is deprecated."', $method, $extractor::class); | ||
| continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This does not look like the right solution to me as it means that a formerly used extractor will now no longer be used leading to a (potentially) different result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I completely agree. I tried to put a messagesomewhere several times, but I was undecided and thought to have the PR rolling to have more feedback / ideas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Also, I thought about strictly checking forgetType and have it default togetTypes and it would work for return values that have only 1 Type in the return array ofgetTypes. I think this change was done before:#54694. Most of the code in property-info thinks BIGINT is string and not this dual type scenario.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
see#57459 for another attempt
Closing in favor of#57459 |