Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Cache] Add a note about the change in the default cache namespace generation to the upgrade guide#57302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1frommbabker:7.1-bc-cache-namespace
Jun 11, 2024

Conversation

@mbabker
Copy link
Contributor

QA
Branch?7.1
Bug fix?no
New feature?no
Deprecations?no
IssuesN/A
LicenseMIT

After deploying the Symfony 7.1 upgrade for a client, we immediately noticed a high rate of cache misses for one of our heavily used controller actions. Digging through the changes for the relevant upstream packages, it looks like this was introduced by way of#52948 and changing the algorithm used for the default cache namespaces when anamespace attribute isn't configured on thecache.pool service tag.

To my knowledge, there is no way to configure a namespace for cache pools using theframework.cache configuration, so through the framework configuration, there is no way to avoid hitting this issue without either manually building cache services or getting creative with a compiler pass that runs before the coreCachePoolPass, so IMO it's best to call out the change in the upgrade guide.

@nicolas-grekas
Copy link
Member

I wouldn't describe this as a BC break. We consider that a minor update isn't required to not invalidate caches (but we'd prefer when possible). Here, it's too late for reverting IMHO.
Can you also add a note in the UPGRADE file at the root of the repo? (and remove the "BC Break" prefix)

@mbabkermbabkerforce-pushed the7.1-bc-cache-namespace branch fromc652caf tof536f3cCompareJune 11, 2024 13:33
@mbabkermbabker changed the title[Cache] Note a breaking change in the cache namespace generation inCachePoolPass[Cache] Add a note about the change in the default cache namespace generation to the upgrade guideJun 11, 2024
@mbabker
Copy link
ContributorAuthor

PR updated

@fabpot
Copy link
Member

Thank you@mbabker.

@fabpotfabpot merged commit954dfa7 intosymfony:7.1Jun 11, 2024
@mbabkermbabker deleted the 7.1-bc-cache-namespace branchJune 11, 2024 15:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

4 participants

@mbabker@nicolas-grekas@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp