Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] Add a note about the change in the default cache namespace generation to the upgrade guide#57302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedJun 11, 2024
I wouldn't describe this as a BC break. We consider that a minor update isn't required to not invalidate caches (but we'd prefer when possible). Here, it's too late for reverting IMHO. |
… to the upgrade guide
c652caf tof536f3cCompareCachePoolPassmbabker commentedJun 11, 2024
PR updated |
fabpot commentedJun 11, 2024
Thank you@mbabker. |
After deploying the Symfony 7.1 upgrade for a client, we immediately noticed a high rate of cache misses for one of our heavily used controller actions. Digging through the changes for the relevant upstream packages, it looks like this was introduced by way of#52948 and changing the algorithm used for the default cache namespaces when a
namespaceattribute isn't configured on thecache.poolservice tag.To my knowledge, there is no way to configure a namespace for cache pools using the
framework.cacheconfiguration, so through the framework configuration, there is no way to avoid hitting this issue without either manually building cache services or getting creative with a compiler pass that runs before the coreCachePoolPass, so IMO it's best to call out the change in the upgrade guide.