Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[String] Fix Inflector for 'hardware'#57234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4frompodhy:inflector_plural_hardware
Jun 3, 2024

Conversation

@podhy
Copy link
Contributor

@podhypodhy commentedMay 30, 2024•
edited by OskarStark
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Issues-
LicenseMIT

Hello,
this PR fixes problem when inflectinghardware word intohardwares. This word should not be inflected.

Please make someone review because I'm not 100% sure if this is the right way how to fix it.

Thank you.

Btw: older versions are also affected and it should be possible to merge it there

@fabpot
Copy link
Member

Can you rebase to get rid of the merge commit and maybe rebase on 5.4?

derrabus reacted with thumbs up emoji

@xabbuhxabbuh modified the milestones:7.1,5.4May 31, 2024
Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@fabpotfabpotforce-pushed theinflector_plural_hardware branch from16c4691 toc655569CompareJune 3, 2024 06:05
@fabpotfabpot changed the base branch from7.1 to5.4June 3, 2024 06:05
Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've rebased on moved the PR to 5.4.

@fabpot
Copy link
Member

Thank you@podhy.

@fabpotfabpot merged commit22e469e intosymfony:5.4Jun 3, 2024
@podhy
Copy link
ContributorAuthor

@fabpot sorry for missing rebase. Had holiday. Thank you for merge.

@fabpotfabpot mentioned this pull requestJun 4, 2024
This was referencedJun 28, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@podhy@fabpot@OskarStark@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp