Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DoctrineBridge] FixUniqueEntityValidator with proxy object#57188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

HypeMC
Copy link
Member

QA
Branch?7.1
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#57075
LicenseMIT

Before#38662,$fieldValue = $class->reflFields[$fieldName]->getValue($entity); was used to get the value of a property, so it makes sense to keep using it when the object is an entity.

wkania and ker0x reacted with thumbs up emojidmaicher reacted with hooray emoji
@carsonbotcarsonbot added this to the7.1 milestoneMay 27, 2024
@HypeMCHypeMCforce-pushed thefix-uniqueentityvalidator-with-proxy-object branch fromadd9ceb to028dbbbCompareMay 27, 2024 00:29
@HypeMCHypeMCforce-pushed thefix-uniqueentityvalidator-with-proxy-object branch from028dbbb to99f279bCompareMay 27, 2024 00:56
Copy link
Contributor

@dmaicherdmaicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for looking into it 👍

LGTM

@xabbuh
Copy link
Member

Thank you@HypeMC.

@xabbuhxabbuh merged commita2890a6 intosymfony:7.1May 31, 2024
6 of 10 checks passed
@HypeMCHypeMC deleted the fix-uniqueentityvalidator-with-proxy-object branchMay 31, 2024 12:11
@fabpotfabpot mentioned this pull requestJun 4, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dmaicherdmaicherdmaicher approved these changes

@stofstofstof approved these changes

@xabbuhxabbuhxabbuh approved these changes

@wkaniawkaniawkania approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

6 participants
@HypeMC@xabbuh@stof@dmaicher@wkania@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp