Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpUnitBridge] Fix error handler triggered outside of tests#57110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:5.4fromHypeMC:fix-error-handler-triggered-outside-of-testsJun 4, 2024
Merged
[PhpUnitBridge] Fix error handler triggered outside of tests#57110
fabpot merged 1 commit intosymfony:5.4fromHypeMC:fix-error-handler-triggered-outside-of-testsJun 4, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
1 task
Contributor
SpartakusMd commentedJun 3, 2024
Tested the fix and confirm I can run the tests successfully. |
chalasr approved these changesJun 4, 2024
nicolas-grekas approved these changesJun 4, 2024
Member
fabpot commentedJun 4, 2024
Thank you@HypeMC. |
Merged
fabpot added a commit that referenced this pull requestJun 15, 2024
This PR was merged into the 5.4 branch.Discussion----------[PhpUnitBridge] Add missing import| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues | -| License | MITFollow up to#57110, looks like I forgot to commit the use statement. 😞Commits-------661e79a [PhpUnitBridge] Add missing import
This was referencedJun 28, 2024
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error handler should be invoked only if the error occurred inside a test.