Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (seehttps://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
• Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

this PR connect to this PRsymfony/ux#1853

I just noticed thatrenotify is not supported in Firefox and Safari according todeveloper.mozilla.org; and there seem to be more properties than just those 4.

I just noticed thatrenotify is not supported in Firefox and Safari according todeveloper.mozilla.org; and there seem to be more properties than just those 4.

you need this option in google chrome

I just noticed thatrenotify is not supported in Firefox and Safari according todeveloper.mozilla.org; and there seem to be more properties than just those 4.

you need this option in google chrome

Might be the case, couldn't find any example/issue that this is the case, but why excluding other browsers and not use just a simple array to dynamically pass the possible options?

My recommendation:

• Replace args for the options with an array
• Add type doc with a reference to developer.mozilla.org, optionally define array shape
• Just pass the array (Also reduces the named arguments and multiple JSON.parse calls in ux package)

It also looks like the resulting activity stream doesn't fit the spec:https://www.w3.org/TR/activitystreams-vocabulary/#dfn-announce.

This might fit the spec more:

{"@context":"https://www.w3.org/ns/activitystreams","type":"Announce","summary":"subject","mediaType":"application/json","content":"{\"body\":null,\"icon\":null,\"tag\":null,\"renotify\":false}"}

@chapterjason it's a good idea
i close this PR and the PR on the ux side, and try it again.
is this ok?

@ernie76 You don't need to create new ones, just modify it, that's what PRs are about, they are evolving. I really like the initial idea, as it gives more control without creating any JS.

@chapterjason is this so ok now?

Hey@ernie76 a bit busy the last days, only one thing, everything else looks good. 👍🏼

What's the status of this PR? It looks like the description is a bit out of sync? Can you give it some live please?

in MercuryOptions you can now
pass an array with the protertieshttps://developer.mozilla.org/en-US/docs/Web/API/Notification?retiredLocale=de#instance_properties

        new MercureOptions(['https://example.com/books/1'], content: ['tag' => $randonnumber,'body' => 'TEST', 'icon' =>  'https://media.flaticon.com/dist/min/img/logos/flaticon-color-negative.svg'])

what shall i do?

What must i do, to make this to a end?

@ernie76 can you please update the PR header?

Needs a rebase

i can't make a rebase.
can i make a new pullrequest?
i have all changes done.

i can't make a rebase. can i make a new pullrequest? i have all changes done.

Sure, just close this one, create a new one, and reference this one.

new PullRequest under
#60140